feat: approval agent config resolution and provider improvements by larryro · Pull Request #975 · tale-project/tale

larryro · 2026-04-05T13:04:11Z

Summary

Approval cards (human input, location) now resolve agent config from thread metadata instead of using hardcoded defaults, ensuring AI responses use the correct agent and model
Fix auth bypass in approval submission actions — internal mutations lost auth context, and actions lacked org membership verification
Make model selection editable on agent instructions page with interactive multi-select scoped to the agent's provider
Add claude-opus-4.6 and gpt-5.2 to supported models, update provider config schema and UI
Default integrations page to Connected tab and prevent access-denied flash while abilities load

Test plan

Submit a human input approval card and verify it uses the thread's agent config (not default)
Submit a location request approval and verify same behavior
Confirm approval submissions fail for users outside the org (auth check)
Edit supported models on agent instructions page — add/remove models and save
Open integrations settings page and confirm it loads on Connected tab without flash
Open provider settings page and verify edit/save flow works

Summary by CodeRabbit

Release Notes

New Features
- Expanded AI model availability: added support for Anthropic Claude Opus 4.6 and OpenAI GPT-5.2.
- Dynamic model selection interface in agent configuration with searchable model discovery.
- Provider-level default model management by capability (chat, vision, embedding).
Improvements
- Optimized integrations settings with reordered tabs and improved loading states.
- Enhanced approval submission with better error handling and context resolution.
- Improved component performance through better memoization and organization context threading.

…provider settings Approval cards (human input and location requests) now resolve the agent config from the thread's metadata instead of using a hardcoded default. This ensures AI responses use the user's selected agent and model override. Follows the action-wrapper pattern from unified_chat. Also improves provider configuration UI and schema validation.

…nfig in approval tools Use proper type for agent config in human_input and location tools, removing unsafe type assertions and fixing non-null assertion in query narrowing.

Replace the static read-only model list with an interactive multi-select that lets users add and remove supported models from available providers, scoped to the agent's configured provider when set.

Update OpenRouter provider secrets with rotated encryption.

…s denied flash Show skeleton while abilities load so the access denied check doesn't flash before permissions are resolved. Default tab changed to "connected" and tab order swapped to match priority.

…tions The internal mutations called from actions used ctx.auth.getUserIdentity() which returns null in Convex internalMutation context, causing all approval submissions to fail. Additionally, the action layer lacked organization membership verification, allowing cross-org authorization bypass. - Pass respondedBy/approvedBy as explicit args from action to mutation - Add verifyOrganizationMembership check in both approval actions - Remove deprecated public mutations (dead code per AGENTS.md) - Deduplicate getApprovalContext query into approvals/internal_queries - Extract shared DEFAULT_AGENT_CONFIG and return validator - Add console.warn logging to catch blocks (no-empty-catch rule) - Memoize modelId in approval card components - Fix fragile JSON.stringify isDirty check with explicit field comparison - Remove 6 unused i18n keys from en.json

greptile-apps

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Stack component only accepts integer gap values (0-12). Change 0.5 to 1 to fix TS2322 type error caught by CI.

coderabbitai · 2026-04-05T13:20:26Z

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

This PR refactors default model selection from per-model default: boolean flags to a provider-level defaults map associating capability tags (chat, vision, embedding) to model IDs. It includes schema updates with migration logic to convert legacy defaults, changes to provider loading and model resolution logic, and extends approval submission workflows to include model ID tracking and agent config resolution. The frontend is updated with dynamic model management UI, new Convex actions for approval submissions with authentication, and additional context passing for organizationId.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Possibly related PRs

feat(platform): add request user location agent tool #841 — Implements request_user_location feature with location approval flows, sharing Convex actions/mutations patterns and approval submission schema changes with this PR.
feat(integrations): SQL database integration with approval workflow #35 — Modifies approval and agent tooling Convex code, including approval validators and submission flows that overlap with the refactored approval action/mutation structure.
feat(platform): resolve agent from thread metadata and fix workflow output extraction #828 — Modifies thread metadata-based agent resolution (agentSlug lookup in threadMetadata), which is directly used in the new approval action context resolution logic.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 24.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main changes: approval agent config resolution and provider improvements are the core objectives evident throughout the changeset.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feat/approval-agent-config-and-provider-improvements

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

larryro added 7 commits April 5, 2026 19:01

fix: replace untyped Record<string, unknown> with SerializableAgentCo…

33d1ef3

…nfig in approval tools Use proper type for agent config in human_input and location tools, removing unsafe type assertions and fixing non-null assertion in query narrowing.

feat(ui): make model selection editable on agent instructions page

5190870

Replace the static read-only model list with an interactive multi-select that lets users add and remove supported models from available providers, scoped to the agent's configured provider when set.

feat: add claude-opus-4.6 and gpt-5.2 to chat agent supported models

4dba12c

Update OpenRouter provider secrets with rotated encryption.

fix(ui): default integrations page to Connected tab and prevent acces…

34b1865

…s denied flash Show skeleton while abilities load so the access denied check doesn't flash before permissions are resolved. Default tab changed to "connected" and tab order swapped to match priority.

chore: remove unused example workflow JSON

c2a7a14

greptile-apps Bot reviewed Apr 5, 2026

View reviewed changes

fix: use valid Stack gap value in provider settings page

a9af639

Stack component only accepts integer gap values (0-12). Change 0.5 to 1 to fix TS2322 type error caught by CI.

larryro merged commit 03c760a into main Apr 5, 2026
15 checks passed

larryro deleted the feat/approval-agent-config-and-provider-improvements branch April 5, 2026 13:11

yannickmonney pushed a commit that referenced this pull request Apr 8, 2026

feat: approval agent config resolution and provider improvements (#975)

8874a87

coderabbitai Bot mentioned this pull request Apr 11, 2026

feat(platform): add multi-team agent access control #1399

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: approval agent config resolution and provider improvements#975

feat: approval agent config resolution and provider improvements#975
larryro merged 8 commits into
mainfrom
feat/approval-agent-config-and-provider-improvements

larryro commented Apr 5, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

greptile-apps Bot left a comment

Uh oh!

Uh oh!

coderabbitai Bot commented Apr 5, 2026

Review failed

Walkthrough

Estimated code review effort

Possibly related PRs

❌ Failed checks (1 warning)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

larryro commented Apr 5, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Summary by CodeRabbit

Release Notes

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai Bot commented Apr 5, 2026

Review failed

Walkthrough

Estimated code review effort

Possibly related PRs

❌ Failed checks (1 warning)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

larryro commented Apr 5, 2026 •

edited by coderabbitai Bot

Loading