Merged
Conversation
tale
requested changes
Feb 24, 2026
Owner
tale
left a comment
tale
left a comment
There was a problem hiding this comment.
Except for the default config, LGTM
| # of custom hinting. | ||
| # extra_params: | ||
| # prompt: "select_account" # Example: force account selection on Google | ||
| # Set to false to define OIDC config without enabling it. |
Owner
There was a problem hiding this comment.
Looks like the formatter messed up here, you may have to manually force a reindent.
Contributor
Author
There was a problem hiding this comment.
@tale , I pushed this change. Sorry I missed that, I'm giving my age away.
allows defining oidc config without enabling it
drifterza
force-pushed
the
feature/oidc-enabled-flag
branch
from
8562a1f to
30dd718
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #442
Adds an
enabledfield to the OIDC config that defaults to true. When set to false, OIDC auth is disabled even if the rest of the config is present.Useful for Helm chart templating where you want to define the structure without enabling it.