Merged
Conversation
junglebarry
commented
Jul 17, 2025
Comment on lines
+1
to
+2
| assets/example-form.js | ||
| assets/FormValidator.js |
Contributor
Author
There was a problem hiding this comment.
We don't - yet - want to reformat these automatically.
| @@ -46,16 +46,16 @@ FormValidator.prototype.showSummary = function() { | |||
| } | |||
Contributor
Author
There was a problem hiding this comment.
This is utterly misleading. This file has not been renamed; it's been deleted.
docs/assets/FormValidator.js is generated from assets/FormValidator.js, using npm run build.
| @@ -5,7 +5,7 @@ validator.addValidator("email", [ | |||
| method: function (field) { | |||
Contributor
Author
There was a problem hiding this comment.
This is utterly misleading. This file has not been renamed; it's been deleted.
docs/assets/example-form.js is generated from assets/example-form.js, using npm run build.
| "homepage": "https://github.com/techfromsage/bootstrap-theme#readme", | ||
| "scripts": { | ||
| "build": "npm-run-all build:*", | ||
| "build:assets": "mkdir -p docs/assets && cp -r assets/* docs/assets/", |
Contributor
Author
There was a problem hiding this comment.
copy all assets - including JS files.
astilla
approved these changes
Jul 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have two variants of the current forms -
formsAandformsB- which appear to be experiments that do not live under source control properly. Here, we remove these variants, and consolidate on a singleformsexample.