Refactor a reference to label rolls #31
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keeping labels of lists consistent. Previous label was rolls, during lesson refactor edit label to roll_names. 1 label was missed.
|
Hi. I'm guessing this is meant to go back to your fork. We generally don't accept PRs that make changes to the content of the code unless there is a true bug. We want what is in the repo to be as close as possible to what students see on the screen. Is there a problem I missed? |
|
Oh, I see, you want to mirror what I see on the video. Then if that is the
case, there is no issue. Please close my PR.
However, can you help me understand but do you provided the solution for
the practices? I'm on Ch 7 for the beginner course. I thought that I could
compare what I wrote for an answer to a provided file. But I didn't seem to
find one that mirror the practice for ch 7. Please advise.
…On Mon, Dec 7, 2020 at 10:44 AM Michael Kennedy ***@***.***> wrote:
Hi. I'm guessing this is meant to go back to your fork. We generally don't
accept PRs that make changes to the content of the code unless there is a
true bug. We want what is in the repo to be as close as possible to what
students see on the screen. Is there a problem I missed?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#31 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC6P5FATCKBBR4ERGVVEK5LSTUO7DANCNFSM4UP4JNCA>
.
--
Respectfully Mr Israel Luna
|
|
Ok, I'll close it. You can find all the solutions over here. https://github.com/talkpython/python-for-absolute-beginners-course/tree/master/solutions :) |
|
Awesome! Thanks so much.
On Mon, Dec 7, 2020 at 12:45 PM Michael Kennedy ***@***.***> wrote:
Ok, I'll close it. You can find all the solutions over here.
https://github.com/talkpython/python-for-absolute-beginners-course/tree/master/solutions
:)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#31 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC6P5FESBNXBUZAUWRS7XZTSTU5F3ANCNFSM4UP4JNCA>
.
--
Respectfully Mr Israel Luna
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping labels of lists consistent. Previous label was rolls, during lesson refactor edit label to roll_names. 1 label was missed.