Skip to content

Tracks#107

Merged
miporto merged 215 commits into
masterfrom
tracks
May 8, 2017
Merged

Tracks#107
miporto merged 215 commits into
masterfrom
tracks

Conversation

@aibarbetta
Copy link
Copy Markdown
Member

@aibarbetta aibarbetta commented May 5, 2017

#23 in progress

miporto and others added 30 commits April 14, 2017 00:19
@miporto
Add linter and fix linting
30a8718
@aibarbetta
Add cors middleware
8239e4b
@miporto
Fix more linting errors
2387584
@miporto
Fix remaining linting errors.
5f32816
@miporto
Merge branch 'develop' into eslint
1887466
@miporto
Enable linting for client
0bd8bf2
@miporto
Merge branch 'eslint' of https://github.com/tallerify/tallerify-catalog…
475e3df 
… into eslint
@miporto
Run code linter after success and code coverage analysis
0aa1b96
@miporto
Run code linter after success and code coverage analysis
be24510
@miporto
Merge pull request #55 from tallerify/eslint
6c8d5b1 
Add code linting
@miporto
Add link to wiki
8acba88
@miporto
Typo
cc6ed68
@miporto
Update node version to last one
64dead7
@miporto
Update Dockerfile
31fe3dd
@miporto
Merge pull request #56 from tallerify/upgrade-node
3945b34 
Update node version to last one
@aibarbetta
Delete client files
bb24c57
@aibarbetta
Clear client dependencies and scripts
c9361de
@aibarbetta
Add new homepage
828e18b
@aibarbetta
Rename server dir to src
9d0b2e5
@aibarbetta
Merge pull request #63 from tallerify/cleanup
3371e96 
Client removal
@aibarbetta
Create user with default image
df41b35
@aibarbetta
Update tests
7cf0067
@aibarbetta
Merge pull request #65 from tallerify/default-image
1887567 
Create user with default image
@aibarbetta
Add admin model and endpoints
0f4cff6
@aibarbetta
Delete href attribute from admin table
ddf2873
@aibarbetta
Add test for admin endpoints
ed6a496
@aibarbetta
Split test constants
e5c9f9b
@aibarbetta
Add token endpoint for admins
2a45dd2
@aibarbetta
Add tests for admin token generation
a4edf0b
@aibarbetta
Merge pull request #67 from tallerify/admin
011bef5 
Admin model, endpoints and token generation
aibarbetta and others added 26 commits May 3, 2017 03:35
@aibarbetta
Format get tracks and add track responses
c8e7e37
@aibarbetta
Add endpoints to get and delete a track
b54b0cd
@aibarbetta
Update track endpoint
9946478
@aibarbetta
Update routes index
772b74a
@miporto
Udate error code and send error message in reject
e4592a1 
* Generate user for db in specific function.
* Update tokens
@miporto
Validate user returned by Fb api
5ee16e8
@miporto
Set default value for missing attributes
7f1bfee
@miporto
Change default values
5416dbf 
* Make username lowercase
* Set last name as last element in array of names
@miporto
Add fields to facebook request
7629357 
* Encapsulate facebook user creation in it's own function
* Update tokens
@miporto
Change mandatory attributes of fb user
a06d13f 
* Change tokens for ones that comply with new mandatory attributes.
* Only use default value with country
@miporto
Merge pull request #101 from tallerify/SS-98
6e99c15 
Add facebook login tests
@aibarbetta
Track creation tests
52b92e0
@aibarbetta
Track deletion tests
2650387
@aibarbetta
Track fetch tests
7b32edc
@aibarbetta
Track update tests (2 test failing due to empty implementation)
bca41a4
@miporto
Change status code of nonExistentCredentials
b8d6f71 
Change from 500 to 400
@miporto
Update tests with new status codes
bfc0e26
@miporto
Merge pull request #103 from tallerify/fb-integration
069daa3 
Facebook integration
@aibarbetta
xtreme pair programming
a80a39b
@aibarbetta
Track like and dislike
2a0885c
@aibarbetta
Get track popularity endpoint
eca6b99
@aibarbetta
Half of track rating
35da267
@miporto
Update to new api specification
1cfa425
@miporto
Unignore .env file and add it to repo
28da983
@aibarbetta
Typo
78e0840
@aibarbetta
Merge branch 'develop' of https://github.com/tallerify/shared-server …
d086916 
…into tracks
@aibarbetta aibarbetta requested a review from miporto May 5, 2017 14:43
@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2017 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@3bad91c). Click here to learn what that means.
The diff coverage is 86.41%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #107   +/-   ##
========================================
  Coverage          ?   86.5%           
========================================
  Files             ?      21           
  Lines             ?     578           
  Branches          ?      27           
========================================
  Hits              ?     500           
  Misses            ?      78           
  Partials          ?       0
Impacted Files Coverage Δ
src/handlers/db/generalHandler.js 100% <100%> (ø)
src/handlers/db/artistTrackHandler.js 100% <100%> (ø)
src/database/index.js 100% <100%> (ø)
src/database/knexfile.js 100% <100%> (ø)
src/database/migrations/migrations.js 100% <100%> (ø)
src/database/tableNames.js 100% <100%> (ø)
src/handlers/db/index.js 100% <100%> (ø)
src/utils/logger.js 100% <100%> (ø)
src/routes/track.js 53.96% <53.96%> (ø)
src/database/database.js 66.66% <66.66%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bad91c...d086916. Read the comment docs.

@miporto miporto merged commit 200fc46 into master May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miporto miporto miporto approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aibarbetta @miporto