Skip to content

fix(release): respect partial artifacts during npm dry run#29

Merged
Abdulmuiz44 merged 1 commit into
mainfrom
fix/codra-npm-prepack-partial-artifacts
Jun 2, 2026
Merged

fix(release): respect partial artifacts during npm dry run#29
Abdulmuiz44 merged 1 commit into
mainfrom
fix/codra-npm-prepack-partial-artifacts

Conversation

@Abdulmuiz44
Copy link
Copy Markdown
Collaborator

  • Fixes release dry-run packaging when darwin-x64 is intentionally skipped.
  • Passes partial/expected platform settings consistently through prepack and pack:dry.
  • Keeps publish=true strict by default.
  • Adds .env to gitignore so local NPM_TOKEN is never committed.
  • Does not publish to npm.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3890f5ed03

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +59 to +60
if (process.env.CODRA_ALLOW_PARTIAL_BINARIES === '1') {
return true;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Do not skip the artifact rebuild after wrapper tests

In the default dry-run release path (publish=false, so CODRA_ALLOW_PARTIAL_BINARIES=1), the workflow runs npm test between build:from-artifacts and both npm pack steps; scripts/test.js then removes bin/native in its finally block and reruns build.js, leaving only the package runner's host binary. Because these lines return as soon as any installed binary exists, prepack skips rebuilding from the downloaded artifacts and the uploaded tarball can contain only linux-x64 instead of the partial release matrix (linux/darwin-arm64/windows). The pack dry-run also won't catch this when CODRA_EXPECT_PLATFORMS is empty for dry runs.

Useful? React with 👍 / 👎.

@Abdulmuiz44 Abdulmuiz44 merged commit 20a7ff2 into main Jun 2, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant