fix(release): respect partial artifacts during npm dry run#29
Conversation
Abdulmuiz44
commented
Jun 2, 2026
- Fixes release dry-run packaging when darwin-x64 is intentionally skipped.
- Passes partial/expected platform settings consistently through prepack and pack:dry.
- Keeps publish=true strict by default.
- Adds .env to gitignore so local NPM_TOKEN is never committed.
- Does not publish to npm.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3890f5ed03
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (process.env.CODRA_ALLOW_PARTIAL_BINARIES === '1') { | ||
| return true; |
There was a problem hiding this comment.
Do not skip the artifact rebuild after wrapper tests
In the default dry-run release path (publish=false, so CODRA_ALLOW_PARTIAL_BINARIES=1), the workflow runs npm test between build:from-artifacts and both npm pack steps; scripts/test.js then removes bin/native in its finally block and reruns build.js, leaving only the package runner's host binary. Because these lines return as soon as any installed binary exists, prepack skips rebuilding from the downloaded artifacts and the uploaded tarball can contain only linux-x64 instead of the partial release matrix (linux/darwin-arm64/windows). The pack dry-run also won't catch this when CODRA_EXPECT_PLATFORMS is empty for dry runs.
Useful? React with 👍 / 👎.