Refine composer menu layout#109
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 320d629abb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <span className="rounded-full border border-tera-border bg-white/[0.03] px-3 py-1 text-[0.68rem] font-medium text-tera-secondary"> | ||
| {pendingAttachments.length ? `${pendingAttachments.length} added` : 'Optional'} | ||
| </span> |
There was a problem hiding this comment.
Restore removal controls for pending attachments
After this UI refactor, pending uploads are only summarized as a count and there is no longer any control to remove a specific file (or clear all) before sending. In practice, if a user attaches the wrong document/image, they must either send it anyway or abandon the draft, which is a real regression from the prior onRemove chip behavior and can lead to accidental file sharing.
Useful? React with 👍 / 👎.
| {entry.userMessage.attachments.map((att, idx) => ( | ||
| <div key={idx} className="flex items-center gap-2 rounded-lg bg-black/5 px-3 py-2 text-xs"> | ||
| <span>{att.type === 'image' ? '🖼️' : '📄'}</span> | ||
| <span>{att.type === 'image' ? '🖼ï¸' : '📄'}</span> |
There was a problem hiding this comment.
Replace garbled attachment emoji literals
The attachment type indicator now uses mojibake strings (🖼� / 📄) instead of valid emoji characters, so users will see corrupted glyphs in chat history rather than the intended image/file icons. This is a visible regression in message rendering.
Useful? React with 👍 / 👎.
| <button | ||
| key={surface.id} | ||
| type="button" | ||
| onClick={() => setSelectedMode(surface.id)} |
There was a problem hiding this comment.
Disable non-functional Image surface option
The new Surface picker makes Image selectable, but selecting it does not change request behavior: message processing still only branches on researchMode and otherwise sends the current chat mode, so Image currently behaves like regular chat while presenting itself as a distinct destination. This mismatch can mislead users into thinking prompts are routed to an image workflow when they are not.
Useful? React with 👍 / 👎.
Polishes the + composer menu into a cleaner desktop/mobile drawer with grouped response styles, surface selection, and attachment actions. This is a UI pass only; we can tune spacing and hierarchy later.