Skip to content

Refine composer menu layout#109

Merged
Abdulmuiz44 merged 1 commit into
mainfrom
codex/cloudflare-deploy
May 26, 2026
Merged

Refine composer menu layout#109
Abdulmuiz44 merged 1 commit into
mainfrom
codex/cloudflare-deploy

Conversation

@Abdulmuiz44
Copy link
Copy Markdown
Collaborator

Polishes the + composer menu into a cleaner desktop/mobile drawer with grouped response styles, surface selection, and attachment actions. This is a UI pass only; we can tune spacing and hierarchy later.

@Abdulmuiz44 Abdulmuiz44 merged commit daee57b into main May 26, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 320d629abb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +966 to +968
<span className="rounded-full border border-tera-border bg-white/[0.03] px-3 py-1 text-[0.68rem] font-medium text-tera-secondary">
{pendingAttachments.length ? `${pendingAttachments.length} added` : 'Optional'}
</span>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore removal controls for pending attachments

After this UI refactor, pending uploads are only summarized as a count and there is no longer any control to remove a specific file (or clear all) before sending. In practice, if a user attaches the wrong document/image, they must either send it anyway or abandon the draft, which is a real regression from the prior onRemove chip behavior and can lead to accidental file sharing.

Useful? React with 👍 / 👎.

{entry.userMessage.attachments.map((att, idx) => (
<div key={idx} className="flex items-center gap-2 rounded-lg bg-black/5 px-3 py-2 text-xs">
<span>{att.type === 'image' ? '🖼️' : '📄'}</span>
<span>{att.type === 'image' ? '🖼️' : '📄'}</span>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Replace garbled attachment emoji literals

The attachment type indicator now uses mojibake strings (🖼� / 📄) instead of valid emoji characters, so users will see corrupted glyphs in chat history rather than the intended image/file icons. This is a visible regression in message rendering.

Useful? React with 👍 / 👎.

<button
key={surface.id}
type="button"
onClick={() => setSelectedMode(surface.id)}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Disable non-functional Image surface option

The new Surface picker makes Image selectable, but selecting it does not change request behavior: message processing still only branches on researchMode and otherwise sends the current chat mode, so Image currently behaves like regular chat while presenting itself as a distinct destination. This mismatch can mislead users into thinking prompts are routed to an image workflow when they are not.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant