Properly position the cursor at the first stop in some cases when inserting snippets without editor support #2017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applies when: - there is text on the line after the inserted snippet - the first stop in the snippet is on the last (or only) line Also documents an assumption in move_to_correct_column that caused the incorrect behavior.
| ) | ||
|
|
||
| RE_STOP = re.compile(r"\$(\d+|\w+)|\$\{(\d+|\w+)\}|\$\{(\d+|\w+):(.+)\}") | ||
| RE_STOP = re.compile(r"\\?(?:\$(\d+|\w+)|\$\{(\d+|\w+)\}|\$\{(\d+|\w+):(.+)\})") |
Collaborator
There was a problem hiding this comment.
This is now complicated enough that it probably warrants a comment breaking down the different parts.
Collaborator
Author
There was a problem hiding this comment.
Agreed! Commenting the regex made me realize I was doing unnecessary work when matching a \$.
AndreasArvidsson
approved these changes
Sep 14, 2025
Don't bother to match anything further after we've found \$.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies when:
Also documents an assumption in
move_to_correct_columnthat caused the incorrect behavior.Per discussion on Slack, we may want to change the behavior of
move_to_correct_columnto not go to the end of the line, but this involves different tradeoffs that should be discussed further.