Extract inferred_early_responses into free function to avoid monomorphization#293
Merged
jplatte merged 1 commit intotamasfe:mainfrom Mar 18, 2026
Merged
Conversation
…hization Follow-up to tamasfe#287: the method doesn't depend on T, so delegating to a free function avoids redundant codegen per concrete type. Also adds inferred_early_responses to JsonDeserializer via the same function.
kieled
force-pushed
the
fix/json-monomorphization
branch
from
3722733 to
0f2959e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #287 per review feedback.
Summary
inferred_early_responseslogic fromimpl<T> OperationInput for axum::Json<T>into a free functioninferred_early_responses_json()to avoid unnecessary monomorphization perT.inferred_early_responsestoJsonDeserializer<T>via the same free function.Test Plan
cargo test -p aide --all-features --lib