test(analyze-runs): deterministic correlation tests (kill Math.random flake)#122
Merged
Conversation
drewstone
approved these changes
May 27, 2026
Contributor
drewstone
left a comment
drewstone
left a comment
There was a problem hiding this comment.
✅ Auto-approved tangletools PR — 988bde92
This PR was opened by the trusted tangletools automation account.
The full PR reviewer audit still runs separately and will publish findings if it detects issues.
tangletools · auto-approval · reason: tangletools_author · 2026-05-27T19:32:54Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two correlation tests in tests/contract-analyze-runs.test.ts used Math.random() to seed engagement values. The first ("linear reward model") could occasionally fail when random noise pushed Pearson below 0.9; the second ("weak correlation") could occasionally pass when random sampling correlated >0.3 with composite by chance. Both now use deterministic noise / alternating pattern instead.
Tests: 11 / 11 passing locally, 1427 / 1427 overall.