Skip to content

chore(hygiene): fix stale CLAUDE.md code-map; (wip) de-dup steer-firewall + bench stats#183

Merged
drewstone merged 1 commit into
mainfrom
chore/architecture-hygiene
Jun 6, 2026
Merged

chore(hygiene): fix stale CLAUDE.md code-map; (wip) de-dup steer-firewall + bench stats#183
drewstone merged 1 commit into
mainfrom
chore/architecture-hygiene

Conversation

@drewstone
Copy link
Copy Markdown
Contributor

Pays down the architecture debt the self-audit found.

Done: CLAUDE.md code-map was actively misleading — cited src/loops/, program.ts, runProgram, and a drivers/ subdir, none of which exist (op-set deleted #168, loops→runtime rename). Rewritten to reflect reality: runLoop (round-synchronous leaf) + Scope/Supervisor (recursive atom, #151) + the personify combinators, with an honest 'two substrates coexist, prefer Scope/Supervisor' note. It misled the audit itself.

Planned on this same branch (next, done carefully — not rushed):

  • De-dup the verbatim steer-firewall (assertTraceDerivedFindings is implemented twice — a private copy in dynamic.ts + the exported one in personify/analyst.ts; a single correctness invariant must have one enforcement site).
  • Extract bench/src/stats.mts (runPool re-export + pairedLift + makeRng) + buildRunRecordFromAttempts; route the 6 gate runners through it and convert clbench-codebase/commit0 to openSandboxRun+openai-compat (kills the duplication the audit flagged).

…/Supervisor atom, program.ts/runProgram deleted (#168)
@tangletools
Copy link
Copy Markdown
Contributor

✅ No Blockers — 6f736fca

Readiness 85/100 · Confidence 65/100 · 1 finding (1 medium)

deepseek: Correctness 85 · Security 85 · Testing 85 · Architecture 85

Full multi-shot audit completed 1/1 planned shots over 1 changed files. Global verifier still owns final merge decision.

🟠 MEDIUM Stale Program/ProgramResult type references survive deletion note — CLAUDE.md

Line 30 lists Program/ProgramResult among types that 'stay in THIS repo', but line 37 (added by this PR) correctly states 'there is no program.ts' and that the 'earlier flat Program op-set + runProgram tree executor was DELETED in #168'. Grep confirms no export of Program or ProgramResult exists anywhere in src/runtime/. These should be removed from line 30 to eliminate the internal contradiction.


tangletools · 2026-06-06T19:17:51Z · trace

Copy link
Copy Markdown
Contributor

@tangletools tangletools left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved — 1 non-blocking finding — 6f736fca

Full multi-shot audit completed 1/1 planned shots over 1 changed files. Global verifier still owns final merge decision.

Full immutable report for this review: trace

Summary comment for this run: full summary


tangletools · 2026-06-06T19:17:51Z · immutable trace

@drewstone drewstone merged commit e1cc398 into main Jun 6, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants