feat(ui): expose InlineCode + themed CodeBlock/CopyButton on primitives#10
Merged
feat(ui): expose InlineCode + themed CodeBlock/CopyButton on primitives#10
Conversation
|
| Name | Type |
|---|---|
| @tangle-network/ui | Minor |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
github-project-automation
Bot
moved this from Building 🏗️
to Completed ✅
in Tangle Universe
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InlineCode,CodeBlock,CopyButton, plusCodeBlockProps/InlineCodePropsfrom@tangle-network/ui/primitives.minor).Why
@tangle-network/sandbox-ui@0.13.0exposesInlineCodevia the deep path./primitives/code-block. After Phase C (sandbox-ui#34) deletes those files in favor of shims, sandbox-ui needs a public@tangle-network/ui/primitivespath to forwardInlineCodefrom. This micro-PR unblocks the consume step and piggybacks on the open release PR (#9) so it ships in the same@tangle-network/ui@1.0.0.Test plan
pnpm -r run build— succeeds;dist/primitives.d.tsincludesInlineCode/InlineCodeProps.pnpm typecheck— green.Refs: #3 (epic), tangle-network/sandbox-ui#34 (consumer).