Skip to content

Productionize Agent Browser Driver: auth-state reuse, modal reliability, CDP perf path, and critical-flow tests#11

Merged
drewstone merged 5 commits into
mainfrom
chore/remove-app-directory
Mar 4, 2026
Merged

Productionize Agent Browser Driver: auth-state reuse, modal reliability, CDP perf path, and critical-flow tests#11
drewstone merged 5 commits into
mainfrom
chore/remove-app-directory

Conversation

@drewstone

@drewstone drewstone commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR consolidates all in-flight work into a single production-ready batch:

  • Auth/session reliability

    • Add CLI + config support for pre-authenticated sessions via --storage-state / storageState
    • Add scripts/save-storage-state.mjs and pnpm auth:save-state for one-time manual login capture
    • Fix modal interaction regression: actions now attempt first, then dismiss blocking overlays only on failure and retry once
  • Observation performance

    • Add CDP fast-path for accessibility snapshot + page metadata
    • Export CDP helpers for reuse
    • Keep Playwright fallback path intact
  • Runner/artifact robustness

    • Improve artifact sink behavior for Playwright video flush edge cases
    • Harden test-runner reliability around artifact/progress handling and critical failure paths
  • Benchmarks + fixtures

    • Add observe and full-agent benchmark scripts plus deterministic fixture pages
  • Coverage

    • Add/expand integration and critical-flow tests for:
      • modal click behavior
      • CDP snapshot + metadata path
      • preview verification
      • parallel worker timeout/deadlock handling
      • artifact persistence behavior
  • Repo hygiene

    • Ignore local auth + benchmark output directories (.auth/, audit-results/, bench/results/)

Why

  • Enables realistic E2E usage against apps with auth without sharing raw secrets/cookies
  • Fixes a concrete blocker seen on real-world auth modals
  • Improves per-turn observation performance while preserving compatibility
  • Raises confidence with non-mocked critical-path tests

Validation

  • pnpm build
  • pnpm test (13 test files, 123 tests passing)
  • Real runs against https://ai.tangle.tools using agent-browser-driver
    • After fix, driver successfully executes auth modal steps (Sign in -> Other sign-in options -> Sign up)
    • Flow then correctly aborts on product-side email verification gate (expected external blocker)

Notes for Review

  • This is intentionally one consolidated PR per request; scope is broad but internally cohesive around reliability/perf/testability.

@drewstone drewstone changed the title Fix modal auth interactions and add storage-state session reuse Productionize Agent Browser Driver: auth-state reuse, modal reliability, CDP perf path, and critical-flow tests Mar 4, 2026
@drewstone drewstone force-pushed the chore/remove-app-directory branch from 61bdbb3 to 39c741e Compare March 4, 2026 02:42
@drewstone drewstone force-pushed the chore/remove-app-directory branch from 39c741e to ed2dcbf Compare March 4, 2026 19:55
@drewstone drewstone merged commit 98a8fe9 into main Mar 4, 2026
0 of 3 checks passed
@drewstone drewstone deleted the chore/remove-app-directory branch March 4, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant