Skip to content

fix(tangle-dapp): dapp crash due to encode address fail#2643

Merged
drewstone merged 2 commits intodevelopfrom
PS/fix-dapp-crash
Nov 9, 2024
Merged

fix(tangle-dapp): dapp crash due to encode address fail#2643
drewstone merged 2 commits intodevelopfrom
PS/fix-dapp-crash

Conversation

@devpavan04
Copy link
Copy Markdown
Contributor

@devpavan04 devpavan04 commented Nov 9, 2024

Summary of changes

  • Fixes dapp crash when trying to connect wallet by catching the error and returning an invalid address url.

Proposed area of change

  • apps/tangle-dapp
  • apps/tangle-cloud
  • libs/webb-ui-components

Associated issue(s)

Screen Recording

CleanShot.2024-11-08.at.18.54.03.mp4

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 9, 2024

Deploy Preview for tangle-dapp ready!

Name Link
🔨 Latest commit 4617eed
🔍 Latest deploy log https://app.netlify.com/sites/tangle-dapp/deploys/672ecfaedb48af00087f33f1
😎 Deploy Preview https://deploy-preview-2643--tangle-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 9, 2024

Deploy Preview for tangle-cloud ready!

Name Link
🔨 Latest commit 4617eed
🔍 Latest deploy log https://app.netlify.com/sites/tangle-cloud/deploys/672ecfae8094f80008f9f116
😎 Deploy Preview https://deploy-preview-2643--tangle-cloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@drewstone drewstone merged commit bce901a into develop Nov 9, 2024
@drewstone drewstone deleted the PS/fix-dapp-crash branch November 9, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Tangle dapp breaks when trying to connect wallet

2 participants