Skip to content

feat(tangle-dapp): Add LST selection modal#2644

Merged
drewstone merged 6 commits intodevelopfrom
yuri/token-select-modal
Nov 11, 2024
Merged

feat(tangle-dapp): Add LST selection modal#2644
drewstone merged 6 commits intodevelopfrom
yuri/token-select-modal

Conversation

@yuri-xyz
Copy link
Copy Markdown
Contributor

@yuri-xyz yuri-xyz commented Nov 10, 2024

Summary of changes

Provide a detailed description of proposed changes.

  • ➕ Clicking on the Select LST dropdown button now opens up a Select LST modal, which is more intuitive to use than the LS pools table.
  • ➕ Added & tested two states for the Select LST modal: Loading & empty.
  • 🐛 Small bug fixes & text copy improvements.

Proposed area of change

Put an x in the boxes that apply.

  • apps/tangle-dapp
  • apps/tangle-cloud
  • libs/webb-ui-components

Associated issue(s)

Specify any issues that can be closed from these changes (e.g. Closes #233).

Screenshots

Staking

Screenshot 2024-11-10 at 23 06 54

Search input working

Screenshot 2024-11-10 at 23 08 08

Loading state

Screenshot 2024-11-10 at 23 11 17

Empty state

Screenshot 2024-11-11 at 00 31 22

Screen Recording

If possible provide screenshots and/or a screen recording of proposed change.

ls-select-lst-modal.mp4

@yuri-xyz yuri-xyz requested a review from drewstone November 10, 2024 17:18
@yuri-xyz yuri-xyz self-assigned this Nov 10, 2024
@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 10, 2024

Deploy Preview for tangle-dapp ready!

Name Link
🔨 Latest commit 7617a85
🔍 Latest deploy log https://app.netlify.com/sites/tangle-dapp/deploys/6731433d6011c40008347f28
😎 Deploy Preview https://deploy-preview-2644--tangle-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 10, 2024

Deploy Preview for tangle-cloud ready!

Name Link
🔨 Latest commit 7617a85
🔍 Latest deploy log https://app.netlify.com/sites/tangle-cloud/deploys/6731433de4e35f0008f3b131
😎 Deploy Preview https://deploy-preview-2644--tangle-cloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yuri-xyz yuri-xyz marked this pull request as ready for review November 10, 2024 23:44
Copy link
Copy Markdown
Contributor

@AtelyPham AtelyPham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@drewstone drewstone merged commit d7235ec into develop Nov 11, 2024
@drewstone drewstone deleted the yuri/token-select-modal branch November 11, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT] Open a Select Token modal when clicking LST dropdowns

3 participants