Skip to content

feat(tangle-dapp): Show LST icons from pool metadata, if set#2653

Merged
drewstone merged 36 commits intodevelopfrom
yuri/add-ls-pools-icon
Nov 29, 2024
Merged

feat(tangle-dapp): Show LST icons from pool metadata, if set#2653
drewstone merged 36 commits intodevelopfrom
yuri/add-ls-pools-icon

Conversation

@yuri-xyz
Copy link
Copy Markdown
Contributor

@yuri-xyz yuri-xyz commented Nov 13, 2024

Summary of changes

Provide a detailed description of proposed changes.

  • ➕ LST icons are now loaded if they're present in LS pools metadata and shown everywhere the LST's icon appears.
  • ➕ Created formatDisplayAmount utility function to standardize balance formatting for UIs.
  • 🔧 Adjusted the precision of some of the balances shown across tables, such as reducing precision for TVLs to reduce the space taken in the case of very small amounts.
  • 🐛 Added missing decimals prop to some token amount table cells that were missing it, which was causing precision problems.
  • 🐛 Fixed a bug when claiming a lot of payouts, now it limits it to 40 to avoid exceeing the block weight limit. This means that the Payout All button will have to be used multiple times if there are more than 40 pending payouts.

Proposed area of change

Put an x in the boxes that apply.

  • apps/tangle-dapp
  • apps/tangle-cloud
  • libs/tangle-shared-ui
  • libs/webb-ui-components

Associated issue(s)

Specify any issues that can be closed from these changes (e.g. Closes #233).

Screen Recording

If possible provide screenshots and/or a screen recording of proposed change.
Screenshot 2024-11-13 at 23 17 49

Screenshot 2024-11-15 at 01 23 18

@yuri-xyz yuri-xyz self-assigned this Nov 13, 2024
@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 13, 2024

Deploy Preview for tangle-cloud ready!

Name Link
🔨 Latest commit 1c9bb75
🔍 Latest deploy log https://app.netlify.com/sites/tangle-cloud/deploys/674a119c0080ff0008ff194f
😎 Deploy Preview https://deploy-preview-2653--tangle-cloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 13, 2024

Deploy Preview for tangle-dapp ready!

Name Link
🔨 Latest commit 1c9bb75
🔍 Latest deploy log https://app.netlify.com/sites/tangle-dapp/deploys/674a119c43568e0008bb7644
😎 Deploy Preview https://deploy-preview-2653--tangle-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yuri-xyz yuri-xyz changed the title feat(tangle-dapp): Show LST icons from pool metadata (if set) feat(tangle-dapp): Show LST icons from pool metadata, if set Nov 25, 2024
@yuri-xyz
Copy link
Copy Markdown
Contributor Author

@AtelyPham Getting an error after updating Substrate types package:
Screenshot 2024-11-25 at 22 15 20

Also, I made two updates to the apps/tangle-dapp/data/restake/RestakeTx/substrate.ts file since the update of the types added a new parameter. Let me know if those are the right parameters 👀 .
Screenshot 2024-11-25 at 22 16 13

@yuri-xyz yuri-xyz marked this pull request as ready for review November 29, 2024 18:23
@yuri-xyz yuri-xyz marked this pull request as draft November 29, 2024 19:08
@yuri-xyz yuri-xyz marked this pull request as ready for review November 29, 2024 19:16
@drewstone drewstone merged commit 56abc20 into develop Nov 29, 2024
@drewstone drewstone deleted the yuri/add-ls-pools-icon branch November 29, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Completed ✅

Development

Successfully merging this pull request may close these issues.

[BUG] Large payout batch causes tx to fail with block limit exceeded [FEAT] Display LS pools icon from metadata (if set)

2 participants