Skip to content

feat(tangle-dapp): Setup Tests, Fix Infinite Render on Restaking#2674

Merged
drewstone merged 22 commits intodevelopfrom
trung-tin/setup-tests-fix-infinite-render
Nov 27, 2024
Merged

feat(tangle-dapp): Setup Tests, Fix Infinite Render on Restaking#2674
drewstone merged 22 commits intodevelopfrom
trung-tin/setup-tests-fix-infinite-render

Conversation

@AtelyPham
Copy link
Copy Markdown
Contributor

@AtelyPham AtelyPham commented Nov 26, 2024

Summary of changes

Provide a detailed description of proposed changes.

Proposed area of change

Put an x in the boxes that apply.

  • apps/tangle-dapp
  • apps/tangle-cloud
  • libs/tangle-shared-ui
  • libs/webb-ui-components

Associated issue(s)

Specify any issues that can be closed from these changes (e.g. Closes #233).

  • Closes

Screen Recording

If possible provide screenshots and/or a screen recording of proposed change.

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 26, 2024

Deploy Preview for tangle-cloud ready!

Name Link
🔨 Latest commit d4213ff
🔍 Latest deploy log https://app.netlify.com/sites/tangle-cloud/deploys/67477a4940d56e000888e71b
😎 Deploy Preview https://deploy-preview-2674--tangle-cloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 26, 2024

Deploy Preview for tangle-dapp ready!

Name Link
🔨 Latest commit d4213ff
🔍 Latest deploy log https://app.netlify.com/sites/tangle-dapp/deploys/67477a499fa78d00085cf463
😎 Deploy Preview https://deploy-preview-2674--tangle-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AtelyPham
Copy link
Copy Markdown
Contributor Author

I confirm that the tests were running; however, there is a bug in the circomlibjs npm package that I am unable to update manually due to dependencies on it in @webb-tools/sdk-core and @webb-tools/utils.

I attempted to remove @webb-tools/utils, but removing @webb-tools/sdk-core is more complicated. Therefore, I've decided to focus on removing outdated code and libraries over the weekend.

After completing the tests, I will enable the GitHub Action to run the tests.

@AtelyPham AtelyPham self-assigned this Nov 27, 2024
@AtelyPham AtelyPham marked this pull request as ready for review November 27, 2024 18:25
@drewstone
Copy link
Copy Markdown
Contributor

Ok, will be good to remove those things for sure.

@drewstone drewstone merged commit f44e4c1 into develop Nov 27, 2024
@drewstone drewstone deleted the trung-tin/setup-tests-fix-infinite-render branch November 27, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Completed ✅

Development

Successfully merging this pull request may close these issues.

3 participants