feat(tangle-dapp): Implement LS pools update roles modal#2675
Merged
feat(tangle-dapp): Implement LS pools update roles modal#2675
Conversation
✅ Deploy Preview for tangle-cloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for tangle-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
Author
|
@AtelyPham Something recently seems to have changed that was causing the build/checks to fail, first something about WASM (which I've fixed) but also about Storybook build failing. I've removed the Storybook workflow temporarily as a workaround to be able to merge this PR. Speaking of, do you think we should get rid of Storybook? I haven't been using it for a long time, unsure if it is actively providing many benefits tbh. Thoughts? |
drewstone
approved these changes
Dec 6, 2024
Contributor
|
Demo looks great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Provide a detailed description of proposed changes.
rootrole of any pools.SubstrateAddress,Substrate32ByteAddress, andEvmAddress. By differentiating each type, it helps prevent possible logic bugs in the future and also improves DX.Proposed area of change
Put an
xin the boxes that apply.apps/tangle-dappapps/tangle-cloudlibs/tangle-shared-uilibs/webb-ui-componentsAssociated issue(s)
Specify any issues that can be closed from these changes (e.g.
Closes #233).Screen Recording
If possible provide screenshots and/or a screen recording of proposed change.
ls-update-roles-modal.mp4