chore(abi): sync tnt-core ABI through bindings v0.11.2#3170
Merged
chore(abi): sync tnt-core ABI through bindings v0.11.2#3170
Conversation
Pulls in surface changes that landed in tnt-core PR #118 (slashing correctness) and PR #122 (interface declaration of expireServiceRequest): - disputeSlash is now payable. The contract requires `msg.value == disputeBond` (zero for SLASH_ADMIN, else the configured bond). Today's protocol config has bond=0 so existing call sites still work; flagging for follow-up if/when admin sets a non-zero bond. - expireServiceRequest(uint64) added — permissionless cleanup path that refunds escrow on stale unapproved requests after the grace period. - ServiceRequest gains `bool activated` (post-activation refund guard). - SlashProposal gains disputer/disputeBond/disputeDeadline fields. No UI changes here. Generated by `yarn sync:tnt-core-assets` against tnt-core@abd065c (post-#121); follow-up PR to surface expireServiceRequest in operator/owner UIs once a flow is designed.
✅ Deploy Preview for tangle-dapp ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for tangle-leaderboard ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for tangle-cloud ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regenerates `libs/tangle-shared-ui/src/abi/tangle.ts` from tnt-core@abd065c. Pulls in two upstream merges that the dapp ABI was lagging on:
Why now
The dapp was building against a stale ABI: existing dispute-slash calls compiled fine, but the contract's payable signature wasn't represented in TS, and `expireServiceRequest` simply didn't exist in our typed surface. tnt-core just merged both fixes; resyncing keeps the typed ABI honest.
Diff
One file, +54/-1 lines. Generated entirely by `yarn sync:tnt-core-assets` then `yarn prettier --write`.
Caveat: `disputeSlash` is now payable
`useDisputeSlashTx` calls `disputeSlash(slashId, reason)` without a `value`. The protocol's current `disputeBond` config is `0`, so the call path still works. If/when an admin sets a non-zero bond, the operator-side dispute flow will revert — a follow-up PR should:
Filing this as a follow-up rather than fixing here so the ABI sync stays mechanical and auditable.
Test plan