Skip to content

Update the design for the withdraw modal#96

Merged
AhmedKorim merged 3 commits intomasterfrom
update-withdraw-modal-ui
Jun 7, 2021
Merged

Update the design for the withdraw modal#96
AhmedKorim merged 3 commits intomasterfrom
update-withdraw-modal-ui

Conversation

@nepoche
Copy link
Copy Markdown
Contributor

@nepoche nepoche commented May 28, 2021

This PR updates the withdraw modal to a structure similar to the deposit modal. It removes the old table format in favor of divs with flex layout.

@nepoche nepoche requested review from AhmedKorim and drewstone May 28, 2021 14:38
@nepoche
Copy link
Copy Markdown
Contributor Author

nepoche commented May 28, 2021

WithdrawModalUi

@nepoche
Copy link
Copy Markdown
Contributor Author

nepoche commented May 28, 2021

fix display issue with mixer amount on modal 99999.99999999999 before merging

Comment thread packages/mixer/src/components/Withdraw/WithdrawingModal.tsx
Copy link
Copy Markdown
Contributor

@drewstone drewstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I would suggest keeping all checklist items in the initial post instead of on a specific line. Best to reference things from lines to the main post.

@AhmedKorim
Copy link
Copy Markdown
Contributor

AhmedKorim commented Jun 7, 2021

Merged with the new provider

@AhmedKorim AhmedKorim merged commit 5471502 into master Jun 7, 2021
@AhmedKorim AhmedKorim deleted the update-withdraw-modal-ui branch June 7, 2021 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants