docs: align with unified approveService + expireServiceRequest#146
Merged
docs: align with unified approveService + expireServiceRequest#146
Conversation
tnt-core PR #119 collapsed five approveServiceWith* variants into one approveService(ApprovalParams). PR #122 declared expireServiceRequest on ITangleServices. Updates here: - ITangleServices reference (and generated mirror): replace approveService(uint64,uint8) + 4 approveServiceWith* blocks with the unified entrypoint; document expireServiceRequest, getTeeCommitmentRoot, teeNonceFor, blsPopMessage. - auth-surface: collapse the four approveServiceWith* table rows into one approveService(ApprovalParams) row with a note on opt-in fields. - slashing: rename the per-asset commitment narrative reference from approveServiceWithCommitments to approveService(ApprovalParams) with non-empty securityCommitments. - check-tnt-core-sync: stop tripwiring on the removed signatures; gate on the new unified entrypoint plus expireServiceRequest / getTeeCommitmentRoot / teeNonceFor.
✅ Deploy Preview for tangle-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings the protocol reference docs back in sync with what tnt-core actually exposes today.
Why now
`yarn check:tnt-core-sync` was broken (asserts `function approveServiceWithBls(` is present in tnt-core source; that signature no longer exists). CI doesn't currently invoke this script but it's intended as a contributor tripwire — a broken tripwire is worse than no tripwire.
Test plan