This repository was archived by the owner on Jul 8, 2022. It is now read-only.
Fix bug #235(SF793) #306
Merged
Fix bug #235(SF793) #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API_AsynReplyNotArrived exception was wrongly thrown when asyn call response was received in the last 20ms before the call timeout expiration.
Member
|
Please use "close #" in PR comment or commit to allow GitHub automatically close corresponding issues. |
Ingvord
reviewed
Oct 28, 2016
src/client/proxy_asyn.cpp
Outdated
| ApiAsynNotThereExcept::throw_exception(API_AsynReplyNotArrived, | ||
| desc.str(), | ||
| "Connection::command_inout_reply"); | ||
| if (req.request->poll_response() == false) |
Member
There was a problem hiding this comment.
Nested if can be moved to outer, i.e.
if(i == nb && !req.request->poll_response())
Ingvord
reviewed
Nov 2, 2016
Member
Ingvord
left a comment
Ingvord
left a comment
There was a problem hiding this comment.
Looks like other similar change requests from the first commit are missing here
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API_AsynReplyNotArrived exception was wrongly thrown when asyn call
response was received in the last 20ms before the call timeout expiration.