Skip to content
This repository was archived by the owner on Jul 8, 2022. It is now read-only.

Conversation

@bourtemb
Copy link
Member

@bourtemb bourtemb commented Dec 7, 2016

(Before it was done when executing cmake, leading to tango.h which could be
patched several times and causing compilation errors).
The files generated from the IDL are now generated in CMAKE_CURRENT_BINARY_DIR
because they could depend on the version of omniORB used by the current config.
CMake minimum required version is now 3.0 instead of 2.8. (CMake was failing
with 2.8.11 version).
Added install_libtango custom target to be able to test the installation part
from CLion IDE.

(Before it was done when executing cmake, leading to tango.h which could be
patched several times and causing compilation errors).
The files generated from the IDL are now generated in CMAKE_CURRENT_BINARY_DIR
because they could depend on the version of omniORB used by the current config.
CMake minimum required version is now 3.0 instead of 2.8. (CMake was failing
with 2.8.11 version).
Added install_libtango custom target to be able to test the installation part
from CLion IDE.
@Ingvord Ingvord merged commit c59fe7f into tango-controls:tango-9-lts Dec 8, 2016
@Ingvord
Copy link
Member

Ingvord commented Dec 8, 2016

Nice solution! Much cleaner. Definitely the same should be done for the master.

P.S. please try not to do more than one thing in a PR. For instance, install target could be done in a separate one.

@bourtemb
Copy link
Member Author

bourtemb commented Dec 8, 2016

Right you are! I'll try to refrain from doing several things in a single PR. Sorry for that.
About doing the same on the master, I put this on my todo list (quite busy with other taks right now), unless you want to do it. ;-)

Ingvord pushed a commit to Ingvord/cppTango that referenced this pull request Dec 8, 2016
This was referenced Dec 8, 2016
bourtemb pushed a commit that referenced this pull request Dec 8, 2016
Generates files from IDL only at compilation time and only if necessary
Ingvord pushed a commit that referenced this pull request Dec 15, 2016
Generates files from IDL only at compilation time and only if necessary
@Ingvord
Copy link
Member

Ingvord commented Dec 17, 2016

Looks like due to this tests may now accidentally fail. As make is normally executed in parallel mode and travis always builds from scratch it sometimes can not find generated tango.h. A minor issue, but annoying.

@bourtemb
Copy link
Member Author

bourtemb commented Jan 4, 2017

If tango.h can not be found during parallel make compilation, this means that some dependencies definitions are missing somewhere. During the build, make should not try to build something which requires tango.h if tango.h was not yet generated... We need to fix that indeed.

Ingvord pushed a commit that referenced this pull request Mar 12, 2017
This reverts commit 64f2bd6.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants