This repository was archived by the owner on Jul 8, 2022. It is now read-only.
cppTango-#339: pointer-cast-size-mismatch attrgetsetprop.cpp:200 #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bourtemb
reviewed
Jan 10, 2017
Member
There was a problem hiding this comment.
It seems fine to remove these casts.
The code used to be like the following in the Tango prehistory:
int per = (int)((double)ext->event_period / DELTA_PERIODIC);
It looks like the casts where not removed when the division was no longer needed.
It seems there is the same issue on line 268 with archive_period. Strange that there is no compilation warning. Line 268 should be fixed too.
bourtemb
reviewed
Jan 10, 2017
src/server/attrgetsetprop.cpp
Outdated
| { | ||
| int per = (int)((double)event_period); | ||
| int per = event_period; | ||
| str << per; |
Member
There was a problem hiding this comment.
We could even optimize by replacing lines 201 and 202 with:
str << event_period;
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
progress #339: pointer-cast-size-mismatch attrgetsetprop.cpp:200