Skip to content
This repository was archived by the owner on Jul 8, 2022. It is now read-only.

Fix shift-negative-value compilation warnings reported by g++ 6.3#383

Merged
bourtemb merged 2 commits intotango-controls:tango-9-ltsfrom
bourtemb:fix-shift-negative-value-warnings
Aug 9, 2017
Merged

Fix shift-negative-value compilation warnings reported by g++ 6.3#383
bourtemb merged 2 commits intotango-controls:tango-9-ltsfrom
bourtemb:fix-shift-negative-value-warnings

Conversation

@bourtemb
Copy link
Copy Markdown
Member

No description provided.

@bourtemb
Copy link
Copy Markdown
Member Author

This article was actually quite interesting on this subject, even though the solution they proposed didn't compile on g++ 6.3. I had to add a cast to (int).

But this is suggesting that this code was originally inspired by libjpeg or a similar project... I think it would be fair to add a note in the distribution and documentation to acknowledge their work. Unless I missed it, it looks like this is not done in the latest versions of the Tango distribution.

@bourtemb bourtemb requested review from Ingvord and JeanLucPons July 24, 2017 15:37
@Ingvord
Copy link
Copy Markdown
Member

Ingvord commented Jul 26, 2017

@bourtemb thanks for the very interesting article. In general I would say we have to avoid any optimizations in code (including non-trivial algos)(and especially not proofed by the tests) as usually performance bottlenecks are in <10% of code. Rather we have to focus on modularity and modifiability. Achieving this will give a clear way to test each component independently including performance testing. So we have to refactor, refactor and refactor :)

Talking about bit shifts there are also quite a few puzzlers described in this book. So every Java developer must read this book (@JeanLucPons). General things such as bitwise shifts or double precision computations are common for both languages and can be interesting to every one (@bourtemb).

Copy link
Copy Markdown
Member

@Ingvord Ingvord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bourtemb bourtemb merged commit 3961d41 into tango-controls:tango-9-lts Aug 9, 2017
Ingvord pushed a commit that referenced this pull request Aug 9, 2017
* Fix shift-negative-value compilation warnings
* Added README to acknowledge work from libjpeg team
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants