Skip to content
This repository was archived by the owner on Jul 8, 2022. It is now read-only.

Tango 9 lts - Windows fixes#413

Merged
bourtemb merged 226 commits intotango-controls:tango-9-ltsfrom
NexeyaSGara:tango-9-lts
Dec 7, 2017
Merged

Tango 9 lts - Windows fixes#413
bourtemb merged 226 commits intotango-controls:tango-9-ltsfrom
NexeyaSGara:tango-9-lts

Conversation

@NexeyaSGara
Copy link
Copy Markdown
Collaborator

This pull request add the Windows CMakelist support for the lts branch.

We will use Appveyor for the building process with the CMakeList

Tango::DevDouble double_val;
TS_ASSERT(db_data_r[0] >> double_val);
TS_ASSERT(std::isnan(double_val));
TS_ASSERT(isnan(double_val));
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is breaking the travis CI build with the following error:

/home/tango/src/cpp_test_suite/cxxtest/include/../../new_tests/cxx_nan_inf_in_prop.cpp:222:29: error: call of overloaded 'isnan(Tango::DevDouble&)' is ambiguous

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since it's on the test part, I can revert and we will see test after

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice try! ;-) but this line was not the only one like that... There are many errors similar to this one.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed all in the file ;)

@Ingvord Ingvord added this to the Q4'2017 milestone Nov 29, 2017
Copy link
Copy Markdown
Member

@bourtemb bourtemb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If @NexeyaSGara agrees, I think we can merge this PR since we have reached a point where we can build the software on Windows.
We will fix the CPack install issues and other issues in new PRs.

@Ingvord Ingvord self-requested a review December 5, 2017 15:05
Copy link
Copy Markdown
Member

@Ingvord Ingvord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bourtemb bourtemb merged commit 49b93e8 into tango-controls:tango-9-lts Dec 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants