Skip to content
This repository was archived by the owner on Jul 8, 2022. It is now read-only.

Doxygen: Add searchbar#432

Merged
bourtemb merged 1 commit intotango-controls:tango-9-ltsfrom
t-b:add-searchbar-in-doxygen-output
Feb 19, 2018
Merged

Doxygen: Add searchbar#432
bourtemb merged 1 commit intotango-controls:tango-9-ltsfrom
t-b:add-searchbar-in-doxygen-output

Conversation

@t-b
Copy link
Copy Markdown
Collaborator

@t-b t-b commented Feb 2, 2018

If you think this is a good change then please also update https://tango-controls.github.io/cppTango-docs/.

Copy link
Copy Markdown
Member

@bourtemb bourtemb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a good idea...
I'm wondering why we are not using the default value here... I guess probably because the default value used to be NO in the past.
Did you get the opportunity to test it with cppTango?
The documentation about this parameter is mentioning that the search can be very slow with big projects... I don't know whether cppTango falls into that category?
I guess it also depends on the hardware capabilities on the client side... Nowadays, people have computers with much more memory than in the past.

Copy link
Copy Markdown
Member

@bourtemb bourtemb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried it on a computer with 4GB RAM and it is very responsive. I think this is indeed a very useful feature and an improvement.

@t-b
Copy link
Copy Markdown
Collaborator Author

t-b commented Feb 5, 2018

@bourtemb It is very responsive here. But I also do have a powerful machine.

@bourtemb bourtemb merged commit 0703923 into tango-controls:tango-9-lts Feb 19, 2018
@t-b t-b deleted the add-searchbar-in-doxygen-output branch October 23, 2019 13:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants