Conversation
bourtemb
left a comment
bourtemb
left a comment
There was a problem hiding this comment.
@t-b, thank you very much for this PR which will reduce the number of compilation warnings, which is a good thing. We have conflicts to be resolved in cppapi/server/tango_config.h since this file has been modified by several PRs which have now been merged since you worked on this file.
Could you please try to solve these conflicts?
| #elif ((_MSC_VER >= 1900) && (_MSC_VER < 1910)) | ||
| #define WIN32_VC14 | ||
| #elif (_MSC_VER >= 1910) | ||
| #define WIN32_VC141 |
There was a problem hiding this comment.
It looks like there is no added value in adding a special case for VC141 for the moment so I would keep it simple for the moment and define WIN32_VC14 if (_MSC_VER >= 1900).
|
@bourtemb Sure. Done. |
| #define HAS_THREAD | ||
| #define HAS_TYPE_TRAITS | ||
| #define HAS_VARIADIC_TEMPLATE | ||
| #define HAS_ATTRIBUTE_SPECIFIERS |
There was a problem hiding this comment.
According to the comment on line 142, shouldn't HAS_ATTRIBUTE_SPECIFIERS be defined for GCC >= 4.8 instead of >4.3?
There was a problem hiding this comment.
@t-b , this is probably the reason why Travis CI tests failed on Debian 7, where the compiler is gcc 4.7.2.
There was a problem hiding this comment.
@bourtemb Yes you are totally right. Looks like my conflict resolution messed that up again. Fixed.
GCC supports them since 4.8 [1] and MSVC since 2015 [2]. [1]: https://gcc.gnu.org/projects/cxx-status.html [2]: https://msdn.microsoft.com/en-us/library/hh567368.aspx
This makes it possible to write code like
std::string func()
{
//
Tango::Except::throw_exception(...);
}
without getting a compiler warning.
2 participants
No description provided.