This repository was archived by the owner on Jul 8, 2022. It is now read-only.
Backport replace CORBA::string_dup with Tango::string_dup#474
Merged
bourtemb merged 4 commits intotango-9-ltsfrom Sep 19, 2018
Merged
Backport replace CORBA::string_dup with Tango::string_dup#474bourtemb merged 4 commits intotango-9-ltsfrom
bourtemb merged 4 commits intotango-9-ltsfrom
Conversation
Ingvord
force-pushed
the
backport-replace-corba-string_dup-with-tango
branch
from
a5305b9 to
e746ecd
Compare
t-b
suggested changes
Sep 6, 2018
Collaborator
t-b
left a comment
t-b
left a comment
There was a problem hiding this comment.
Looks good, I've left one comment.
Ingvord
commented
Sep 6, 2018
Member
Author
Ingvord
left a comment
Ingvord
left a comment
There was a problem hiding this comment.
SonarQube analysis found issues:
| // | ||
| // A short inline function to hide the CORBA::string_dup function | ||
| // | ||
| namespace Tango { |
Member
Author
There was a problem hiding this comment.
bourtemb
approved these changes
Sep 18, 2018
Member
bourtemb
left a comment
bourtemb
left a comment
There was a problem hiding this comment.
Looks good to me.
I would suggest to squash the commits to keep a cleaner history in tango-9-lts. Feel free to keep the information about the total time spent on this PR in the final commit message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 65b3e79 - 20min