This repository was archived by the owner on Jul 8, 2022. It is now read-only.
Fix cxx_fwd_att.cpp:749 occasional test failure (#384,#428)#493
Merged
bourtemb merged 2 commits intotango-controls:tango-9-ltsfrom Oct 24, 2018
Merged
Fix cxx_fwd_att.cpp:749 occasional test failure (#384,#428)#493bourtemb merged 2 commits intotango-controls:tango-9-ltsfrom
bourtemb merged 2 commits intotango-controls:tango-9-ltsfrom
Conversation
to CACHE_DEV in test_event_on_a_forwarded_attribute()
Member
Author
|
The error event API_NoDataYet was actually sent because fwd_device DeviceProxy source was set to CACHE by the previous test (test_polling_on_a_forwarded_attribute). So the synchronous call occurring during the event subscription is trying to read from the cache only and gets an exception because there is nothing yet in the cache. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a sleep time after sending AddObjPolling command to the root device and before subscribing event on the forwarded device to give some time for the polling to start up correctly and changed the assertion cb.cb_err == 1 into cb.cb_err == 0.
The test failures we were experiencing before were due to the fact that sometimes (most of the times) an error event was sent with the following exception:
And sometimes, no error event was sent because the polling had enough time to start up correctly on the root device. So there was already a value available in the cache.
So the assertion (cb.cb_err == 1) was wrong in this last case because cb.cb_err was equal to 0.