Skip to content
This repository was archived by the owner on Jul 8, 2022. It is now read-only.

Conversation

@t-b
Copy link
Collaborator

@t-b t-b commented Oct 25, 2019

We don't have the old problems with the void* conversion anymore. Now we
want to explain to the user in detail how to install cppzmq for the
cppTango repository and when installed via the tango source
distribution.

@t-b t-b requested a review from bourtemb October 25, 2019 12:12
@t-b t-b force-pushed the update-install-readme branch from 38c34ec to 854c928 Compare October 25, 2019 12:25
We don't have the old problems with the void* conversion anymore. Now we
want to explain to the user in detail how to install cppzmq for the
cppTango repository and when installed via the tango source
distribution.
@t-b t-b force-pushed the update-install-readme branch from 854c928 to 3811a10 Compare October 25, 2019 13:14
@t-b t-b requested a review from bourtemb October 25, 2019 13:14
Copy link
Member

@bourtemb bourtemb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!
I think we should start to use some special keywords in the commit messages to skip the Travis build (Maybe the same exists for appveyor too) when the commit include only files which are not impacting the builds like .md files?
https://docs.travis-ci.com/user/customizing-the-build/#skipping-a-build

@t-b t-b merged commit d19e6c3 into tango-controls:tango-9-lts Oct 25, 2019
@t-b t-b deleted the update-install-readme branch October 25, 2019 13:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants