This repository was archived by the owner on Jul 8, 2022. It is now read-only.
Add support for group devices in remote TANGO_HOST (attempt 2) #608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test verifies that devices running in a remote Tango instnace (TANGO_HOST different from client's) can be accessed via Group API using wildcard names.
TANGO_HOST is prepended to device names resolved from wildcards if devices are running in remote Tango instance (different than client's. Full device names are needed to instantiate device proxies to these devices.
Collaborator
Author
t-b
reviewed
Nov 2, 2019
Use string stream instead of sprintf when building full device name for group element to prevent buffer overflow.
Specify parameter names in function declarations in Group interface to match function definitions.
t-b
approved these changes
Nov 5, 2019
Collaborator
Author
|
@bourtemb could you please check if the changes are ok for you and can be merged? |
Collaborator
Author
|
@bourtemb is the PR ok from your POV? |
bourtemb
approved these changes
Nov 14, 2019
Member
bourtemb
left a comment
bourtemb
left a comment
There was a problem hiding this comment.
Looks pretty good to me. Thanks! Just a small comment about the usage of std::getenv in the new test.
This was referenced Nov 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correction for following scenario:
tango://H1/my/test/*)Bug:
tango://H1/my/test/*is resolved tomy/test/deviceinstead oftango://H1/my/test/deviceFixes #495