Skip to content
This repository was archived by the owner on Jul 8, 2022. It is now read-only.

Conversation

@t-b
Copy link
Collaborator

@t-b t-b commented Nov 1, 2019

Automate the deployment from appveyor.

We want to publish all artifacts as a new draft prelease on tag push
only.

I've published 9.3.4-rc1 from an environment in appveyor. This is an alternative solution to the inline deployment method.

For playing around I've used an OAuth token from my user. But we can not merge it as it is as using a token from a human user account is unsafe. This OAuth token allows read/write access to all repositories.

I propose to create a machine user which has only access to the cppTango repo and generate an OAuth token for her and use that here. See https://developer.github.com/v3/guides/managing-deploy-keys/#machine-users and https://help.github.com/en/github/authenticating-to-github/creating-a-personal-access-token-for-the-command-line?query=machine%20user.

Close #602.

@t-b t-b requested review from NexeyaSGara and bourtemb November 1, 2019 21:27
@bourtemb
Copy link
Member

I propose to create a machine user which has only access to the cppTango repo and generate an OAuth token for her and use that here.

Sounds good to me.

Copy link
Collaborator

@NexeyaSGara NexeyaSGara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big yes :)
I didn't had the time to study the automatic deployment so I'm ok with that and the machine user

NexeyaSGara
NexeyaSGara previously approved these changes Jan 16, 2020
Automate the deployment from appveyor.

We want to publish all artifacts as a new draft prelease on tag push
only.

For reference see https://www.appveyor.com/docs/deployment/github/ and
https://www.appveyor.com/docs/appveyor-yml/.

I have created a new github machine user named cppTango-bot for that.
And also a personal access token which was encrypted on the appveyor
site.
@t-b t-b force-pushed the automated-appveyor-deployment branch from b7c3bc0 to 9269595 Compare January 26, 2020 17:29
@t-b t-b requested a review from mliszcz as a code owner January 26, 2020 17:29
@t-b
Copy link
Collaborator Author

t-b commented Jan 26, 2020

Updated. @bourtemb Could you grant the new machine user https://github.com/cppTango-bot access to the cppTango repo (and only to that, not to the full orga).

I've already created a personal access token for her.

@t-b t-b added Ready For Merge Candidate For Backport Requires a backport to the release branches labels Jan 26, 2020
@bourtemb
Copy link
Member

Updated. @bourtemb Could you grant the new machine user https://github.com/cppTango-bot access to the cppTango repo (and only to that, not to the full orga).

@t-b , invitation sent to cppTango-bot.
Please tell me if the permissions are not correct.

@cppTango-bot
Copy link
Collaborator

@bourtemb Thanks. Ready to merge I guess.

Copy link
Member

@bourtemb bourtemb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I Tried it on my fork and seems to work as expected.
Thanks @t-b , this will simplify our life when preparing a release.
We need to do the same in the 9.3-backports branch to get it for the 9.3.4 release.

@t-b
Copy link
Collaborator Author

t-b commented Feb 28, 2020

@bourtemb Can you bend the rules and merge with just one approval?

@bourtemb bourtemb merged commit 1ac5821 into tango-controls:tango-9-lts Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Candidate For Backport Requires a backport to the release branches high priority Ready For Merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

appveyor: Add support for automatic uploading of releases to github

4 participants