Skip to content
This repository was archived by the owner on Jul 8, 2022. It is now read-only.

Conversation

@t-b
Copy link
Collaborator

@t-b t-b commented Jan 23, 2020

Undefine interface for Microsoft Visual Studio version 14.0.25431.01 Update 3
comming with _MSC_VER = 1900 to fix compilation error:
"error C2236: unexpected token 'struct'. Did you forget a ';'?

Undefine interface for Microsoft Visual Studio version 14.0.25431.01 Update 3
comming with _MSC_VER = 1900 to fix compilation error:
 "error C2236: unexpected token 'struct'. Did you forget a ';'?
@t-b t-b requested review from bourtemb and mliszcz as code owners January 23, 2020 13:42
@t-b t-b mentioned this pull request Jan 23, 2020
8 tasks
Copy link
Collaborator

@mliszcz mliszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@t-b do you know why we undefine interface only for msvc versions >= 1900? Maybe we could drop this #if completely.

@t-b
Copy link
Collaborator Author

t-b commented Jan 24, 2020

@mliszcz interface is only a define for MSVC 1900 or later. The mid-term solution for tango-9-lts would probably be to rename the struct member and drop the #ifdef.

@t-b t-b merged commit 526c2d1 into tango-controls:9.3-backports Jan 24, 2020
@t-b t-b deleted the avoid-undefined-interface-warning-msvc branch January 24, 2020 10:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants