Skip to content
This repository was archived by the owner on Jul 8, 2022. It is now read-only.

Conversation

@t-b
Copy link
Collaborator

@t-b t-b commented Jan 23, 2020

@lorenzopivetta I needed to disable the tests as well, so I just extracted it into this PR.

@t-b t-b requested review from bourtemb and mliszcz as code owners January 23, 2020 20:49
@lorenzopivetta
Copy link

@t-b thanks. But this does not work with 9.3-backports because of the appveyor.yml
I'll just pick the relevant pieces and prepare a new PR. Is this ok with you?

@t-b
Copy link
Collaborator Author

t-b commented Jan 24, 2020

@lorenzopivetta Yes creating a backport PR would be appreciated.

We now support switching the test suite build off using the standard CTest
option BUILD_TESTING.

This allows environments where the test compilation fails to skip it in
a consistent manner.

This also removes the unconditional call to enable_testing() which the
CTest module now does only if BUILD_TESTING is ON.

Co-authored-by: Michal Liszcz <liszcz.michal@gmail.com>
@t-b t-b force-pushed the add-switch-for-disabling-building-the-tests branch from cbc55ec to a81c158 Compare February 17, 2020 20:26
Copy link
Collaborator

@mliszcz mliszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@t-b t-b added the Candidate For Backport Requires a backport to the release branches label Feb 27, 2020
@t-b t-b removed the Candidate For Backport Requires a backport to the release branches label Feb 28, 2020
Copy link
Member

@bourtemb bourtemb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @t-b

@t-b t-b merged commit 3fda811 into tango-controls:tango-9-lts Mar 4, 2020
@t-b t-b deleted the add-switch-for-disabling-building-the-tests branch March 4, 2020 16:34
@t-b t-b mentioned this pull request Mar 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants