Skip to content
This repository was archived by the owner on Jul 8, 2022. It is now read-only.

Conversation

@t-b
Copy link
Collaborator

@t-b t-b commented Feb 27, 2020

We now support switching the test suite build off using the standard CTest
option BUILD_TESTING.

This allows environments where the test compilation fails to skip it in
a consistent manner.

This also removes the unconditional call to enable_testing() which the
CTest module now does only if BUILD_TESTING is ON.

Co-authored-by: Michal Liszcz liszcz.michal@gmail.com

We now support switching the test suite build off using the standard CTest
option BUILD_TESTING.

This allows environments where the test compilation fails to skip it in
a consistent manner.

This also removes the unconditional call to enable_testing() which the
CTest module now does only if BUILD_TESTING is ON.

Co-authored-by: Michal Liszcz <liszcz.michal@gmail.com>
@t-b t-b requested review from bourtemb and mliszcz as code owners February 27, 2020 14:58
@t-b t-b changed the title CMakeLists.txt: Rework test suite handling Backport: CMakeLists.txt: Rework test suite handling Feb 27, 2020
@t-b t-b changed the title Backport: CMakeLists.txt: Rework test suite handling Backport: CMakeLists.txt: Add option to disable building the test suite Feb 27, 2020
Copy link
Member

@bourtemb bourtemb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @t-b and @mliszcz, looks good to me!

Copy link
Collaborator

@mliszcz mliszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@t-b t-b merged commit adc5421 into tango-controls:9.3-backports Feb 28, 2020
@t-b t-b deleted the add-switch-for-disabling-building-the-tests-backport branch February 28, 2020 10:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants