fix: correct batch handling in _prepare_image_ids for cond_model_input#1
Open
tanishaj12 wants to merge 1 commit into
Open
fix: correct batch handling in _prepare_image_ids for cond_model_input#1tanishaj12 wants to merge 1 commit into
tanishaj12 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes huggingface#13811
Description
In
train_dreambooth_lora_flux2_img2img.py,_prepare_image_idswas being called with a list ofBsingle-image tensors (one per batch element), causing it to assign escalating temporal IDs (T=10, T=20, T=30...) across batch elements — as if they were multiple reference images for a single sample.Since each batch element is an independent training sample with exactly one conditional image, all samples should receive the same temporal ID (T=10). The fix computes IDs for a single sample and expands them across the batch dimension.
Before (buggy):
After (fixed):
Before submitting