ci: add GitHub Action to build Windows EXE using wada.webp icon#2
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 02b1fa563e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| cache: npm | ||
|
|
||
| - name: Install dependencies | ||
| run: npm ci |
There was a problem hiding this comment.
Replace
npm ci with a lockfile-compatible install
The workflow’s install step will fail on every run because npm ci only works when package-lock.json/npm-shrinkwrap.json is present, but this repo currently only tracks bun.lock and this commit does not add an npm lockfile. In that state, the job exits at dependency installation (EUSAGE) before packaging, so tag builds cannot produce the Windows EXE artifact.
Useful? React with 👍 / 👎.
Motivation
wada.webpas the application icon during packaging.Description
.github/workflows/build-windows-exe.ymlthat runs onworkflow_dispatchandpushtagsv*and performs checkout,npm ci, icon conversion, build and artifact upload.wada.webptobuild/icon.icousing ImageMagick viamagick convertbefore packaging.npx electron-builder --win portableto create a Windows portable EXE and uploadsdist/*.exeas an artifact.package.jsonto addscripts.build:win, adevDependencies.electron-builderentry, and abuildconfiguration (appId,productName,directories.output=dist,buildResources=build,files, andwin.target=portablewithicon=build/icon.ico).Testing
node --check main.js,node --check preload.js, andnode --check renderer/app.js, which completed successfully.npm ciandnpx electron-builder --win portableare the commands used by the workflow (no full CI run in this environment).Codex Task