Skip to content

ci: add GitHub Action to build Windows EXE using wada.webp icon#2

Merged
tans merged 1 commit intomainfrom
codex/add-github-action-to-package-exe
Mar 24, 2026
Merged

ci: add GitHub Action to build Windows EXE using wada.webp icon#2
tans merged 1 commit intomainfrom
codex/add-github-action-to-package-exe

Conversation

@tans
Copy link
Copy Markdown
Owner

@tans tans commented Mar 24, 2026

Motivation

  • Provide an automated way to produce a Windows portable EXE for the app from CI.
  • Use the existing wada.webp as the application icon during packaging.
  • Make releases easier by producing build artifacts on tag or manual dispatch.

Description

  • Added workflow .github/workflows/build-windows-exe.yml that runs on workflow_dispatch and push tags v* and performs checkout, npm ci, icon conversion, build and artifact upload.
  • The workflow converts wada.webp to build/icon.ico using ImageMagick via magick convert before packaging.
  • Build step uses npx electron-builder --win portable to create a Windows portable EXE and uploads dist/*.exe as an artifact.
  • Updated package.json to add scripts.build:win, a devDependencies.electron-builder entry, and a build configuration (appId, productName, directories.output=dist, buildResources=build, files, and win.target=portable with icon=build/icon.ico).

Testing

  • Ran syntax checks with node --check main.js, node --check preload.js, and node --check renderer/app.js, which completed successfully.
  • Verified npm ci and npx electron-builder --win portable are the commands used by the workflow (no full CI run in this environment).

Codex Task

@tans tans merged commit 8b37c31 into main Mar 24, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 02b1fa563e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

cache: npm

- name: Install dependencies
run: npm ci
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Replace npm ci with a lockfile-compatible install

The workflow’s install step will fail on every run because npm ci only works when package-lock.json/npm-shrinkwrap.json is present, but this repo currently only tracks bun.lock and this commit does not add an npm lockfile. In that state, the job exits at dependency installation (EUSAGE) before packaging, so tag builds cannot produce the Windows EXE artifact.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant