feat(nx): support rsbuild in Playwright inference#7221
feat(nx): support rsbuild in Playwright inference#7221beaussan merged 1 commit intoTanStack:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Playwright plugin's build system was extended to support multiple toolchains. A Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit bee7d25
☁️ Nx Cloud last updated this comment at |
Summary
rsbuildas a supported Playwright inference toolchain in the Nx Playwright pluginviteorrsbuild) when generating inferred build targetsHow to use rsbuild with Playwright inference
Add
playwrightModesmetadata to your packagepackage.jsonand settoolchaintorsbuild:{ "nx": { "metadata": { "playwrightModes": [ { "toolchain": "rsbuild", "mode": "spa" }, { "toolchain": "rsbuild", "mode": "ssr", "shards": 3 } ] } } }When inferred targets are generated for an
rsbuildmode, the build step uses:rsbuild build && tsc --noEmitSupported modes remain:
ssrspaprerenderpreviewSummary by CodeRabbit
rsbuildas a build toolchain alongsidevite. The plugin now automatically selects and executes the appropriate build command based on the configured toolchain, enabling projects to run end-to-end tests with their preferred build system without manual configuration.