Skip to content

update intent workflow#7243

Merged
schiller-manuel merged 1 commit intoTanStack:mainfrom
LadyBluenotes:update-intent
Apr 23, 2026
Merged

update intent workflow#7243
schiller-manuel merged 1 commit intoTanStack:mainfrom
LadyBluenotes:update-intent

Conversation

@LadyBluenotes
Copy link
Copy Markdown
Member

@LadyBluenotes LadyBluenotes commented Apr 23, 2026

Summary by CodeRabbit

  • Chores
    • Updated skill coverage review workflow to generate comprehensive analysis reports including stale skills and additional review signals with detailed markdown content
    • Improved pull request management with intelligent branch reuse and automatic updates to existing pull request bodies
    • Enhanced error handling for review command failures

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 23, 2026

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

The workflow refactors its intent skill coverage review process: it now runs intent stale --json once, transforms JSON output into review-items.json with stale skills and signals, generates a detailed markdown PR body with grouped signal counts, and implements idempotent PR handling that reuses branches and edits existing PRs instead of always creating new ones.

Changes

Cohort / File(s) Summary
Workflow Refactoring
.github/workflows/check-skills.yml
Restructured intent skill coverage review logic: replaced single stale skills check with JSON transformation into review-items.json containing stale skills and additional signals; changed PR content generation from simple summary/prompt to full markdown pr-body.md with grouped signal counts and detailed agent prompt; implemented idempotent PR handling with branch reuse and existing PR body updates instead of always creating new PR/branch targeting main.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Poem

🐰 Hops with glee through workflow new,
Intent stale skills turned shiny bright,
JSON blooms in review-items true,
PR branches dance, no duplicates in sight!
Idempotent magic, signals aligned—
Rabbit approves this code most refined!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is vague and generic. It states 'update intent workflow' but does not convey the specific nature of the changes, such as the shift to intent skill coverage reviews, JSON transformation logic, or the idempotent PR handling flow. Consider a more descriptive title that highlights the primary change, such as 'Refactor intent workflow for skill coverage reviews' or 'Update intent workflow to use skill coverage signals and idempotent PR handling'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Apr 23, 2026

View your CI Pipeline Execution ↗ for commit b4452c5

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded <1s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2s View ↗

☁️ Nx Cloud last updated this comment at 2026-04-23 23:43:55 UTC

@schiller-manuel schiller-manuel merged commit ea78f99 into TanStack:main Apr 23, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants