[pull] master from paquettg:master #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es needed to work properly
html5 spec has a list of void elements (aka self closing tags) https://www.w3.org/TR/html5/syntax.html#void-elements
Correct cleanupInput option section. Correct spelling.
…tChild, countChildren, getChildren, hasChildren
This change will run the clear() function to empty any caches if an attribute has been changed, added, or removed.
All composer based/distributed libraries should include a local gitignore to prevent the vendor folder from being included. I've included what I would call the default minimum; I was considering leaving composer.lock off the list, but as it's not currently synced it should be included here.
While the Tag test doesn't test this issue, I think it's a good addition. This particular bug/issue isn't triggered until you ask the library to 'render' the html for you. The HtmlTest does infact test this bug and when run on current master it WILL fail; however, it passes with the changes suggested.
related: #222 related: !225 ```html <html> <head></head> <body class="" style="" data-gr-c-s-loaded="true"> 123 <a>456789</a> <span>101112</span> </body> <html> ``` ```javascript document.body.innerText; ``` output ``` 123 456789 101112 ``` ```PHP $html = <<<EOF <body class="" style="" data-gr-c-s-loaded="true"> 123 <a>456789</a> <span>101112</span> </body> EOF; $dom = new Dom(); $dom->load($html); echo $dom->innerText; ``` asset output ``` 123 456789 101112 ```
[dev/3.0.0]feature: innerText property support
Fixed Issue with encoding 227
Fixed a few stray typos
Fixes #247 numbers in comments can cause php fatal errors.
Update README.md
Dev/3.1.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )