CMake imported target is not `taocpp::json` anymore

[SpaceIm]

47edc2f has changed logical target name from json to taocpp-json. But it also changes imported target name as a side effect, which is not taocpp::json anymore (like the ALIAS target which did not change), but taocpp::taocpp-json.

To avoid breaking change in imported target name, you should add to CMakeLists:

set_target_properties(taocpp-json PROPERTIES EXPORT_NAME json)

https://cmake.org/cmake/help/latest/prop_tgt/EXPORT_NAME.html

[d-frey]

I never really understood how this works. If the library is called "json" or the export name is "json" - wouldn't that lead to clashes in other projects that depend on multiple JSON libraries if they all use "json" as their CMake name? How does CMake handle this? I understand putting json into a namespace taocpp::, but the top-level names should be unique, no? And wouldn't your suggestion introduce "json" as a top-level name again?

[SpaceIm]

No, logical target would still be taocpp-json, but imported target would be taocpp::json (the target in CMake config file, ie <NAMESPACE>::<EXPORT_NAME>), so no clash with a json target.