Bump AmbiTap to current main, fix C++20 build break, drop CI PAT requirement#1
Merged
Merged
Conversation
The AmbiTap pin was 23 commits behind main; current main added
math/core/fast_math.h which uses std::bit_cast (C++20), while min-api's
min-posttarget.cmake pins every external target to CXX_STANDARD 17 — so a
submodule bump alone broke every object that reaches fast_math.h. Each
project CMakeLists now requests cxx_std_20 and re-raises CXX_STANDARD to 20
after the min-posttarget include.
Verified: all 11 externals compile clean against the bumped submodule (and
against a sibling AmbiTap checkout via -DAmbiTap_ROOT). Link fails only on
Linux ('-r and -shared' in min-api's post-target flags), which is not a
supported Max target; macOS/Windows unaffected.
README: replace the stale roadmap section with status against the library's
docs/ROADMAP.md, which is now the authoritative plan.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012VeadvCRUHJdneFNwRbFAM
The guard step (which was the reason CI never went green) and the checkout token are no longer needed; the default GITHUB_TOKEN handles the recursive checkout of public submodules. README updated to match. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012VeadvCRUHJdneFNwRbFAM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ee1e5ac(23 commits behind) to current main, which includes the newly mergeddocs/ROADMAP.md.fast_math.husesstd::bit_cast(C++20), while min-api'smin-posttarget.cmakepins every external target toCXX_STANDARD 17. Each project CMakeLists now requestscxx_std_20and re-raisesCXX_STANDARDto 20 after the min-posttarget include. All 11 externals verified compiling clean against the bumped submodule.AMBITAP_PATrequirement — both repos are public now, so the recursive checkout needs no token. This removes the guard step that failed every previous CI run.docs/ROADMAP.md; update the CI section.Test plan
-DAmbiTap_ROOT🤖 Generated with Claude Code
https://claude.ai/code/session_012VeadvCRUHJdneFNwRbFAM
Generated by Claude Code