fix(test/requirement-review): allow degraded review when requirement doc is missing#53
Merged
fix(test/requirement-review): allow degraded review when requirement doc is missing#53
Conversation
…doc is missing ## Changes - PHASES stage 1: detect the "degraded review mode" banner and inform the user upfront - PHASES stage 2.1: skip requirement-doc fetch in degraded mode - PHASES stage 2.6: relax the blocking condition so at least one of requirement doc / story description / design link is enough - Bump test plugin to 0.0.6 and marketplace metadata to 0.1.36 ## Impact - Requirement review no longer rejects Stories that lack the "requirement doc" field, as long as the description or design link can serve as input - The existing happy path is unchanged: Stories with a valid requirement doc still go through the full 5-stage flow - Requires the paired ai-case backend change (validate_prefetch_data + prompt builder) to take effect Generated-By: Claude Code <https://claude.ai/code> Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
Bot
added
scope:plugins
…work class ai-case backend ai_assistant_service.py:_setup_conventions_in_dir reads plugin's CONVENTIONS.md and symlinks it to work_dir/.claude/CONVENTIONS.md as Claude Code SDK input. It is plugin configuration documentation, not a skill output, so it belongs in the framework allowlist alongside PHASES.md / SKILL.md / plugin.json etc. Without this entry, the contract-bridge-check pre-commit hook fails on ai-case with "❌ 缺失声明: CONVENTIONS.md" (1 missing declaration). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
PHASES.md and test-case-writer agent now instruct the model to call the in-process MCP tool save_test_cases for writing *_cases.json. The tool's input_schema (built from the backend Pydantic TestCase) enforces field constraints at generation time, replacing the post-hoc PreToolUse hook schema validation. Bash escape hatch retained for >50-case merges (test_cases.json, final_cases.json) where pure LLM output paths risk token truncation. Bump test plugin to 0.0.7, marketplace metadata to 0.1.37. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Update CONVENTIONS.md "strict validation" section to describe the new layered defense (input_schema -> tool-side validate_cases -> hook redirect) instead of the obsolete PreToolUse hook narrative. Drop "post_complete auto-fix / fallback" framing from test-case-generation/PHASES.md; schema is now enforced at the tool input layer at generation time. Note in _shared/LARGE_FILE_HANDLING.md that mcp__cases__save_test_cases input is subject to the same LLM token limit as Write, so the >50-case Bash-merge rule still applies. Bump marketplace metadata 0.1.37 -> 0.1.38; CHANGELOG and READMEs synced. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
scope:docs
Resolve conflicts: - marketplace.json: keep our 0.1.38 (production+1 from main 0.1.37) and test plugin 0.0.7 - CHANGELOG.md: keep 0.1.38 entry on top, then main's 0.1.37 / 0.1.36 - README.md / README.en.md: take main's spec/git/sync versions, keep our test 0.0.7 - plugins/test/.claude-plugin/plugin.json: keep 0.0.7 - plugins/test/.codex-plugin/plugin.json: keep 0.0.7 (interface block from main retained) - plugins/test/README.md: keep both v0.0.7 (ours) and v0.0.6 (main) entries Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
scope:docs
em0t
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
requirement_doc_link/story_description/design_linkis present, the review proceeds and the skill is told (via a banner injected from the backend) to inform the user that the result has reduced reliability.Test plan
requirement_doc_linkbut has a description and/or design link → should run in degraded mode and surface the banner in chat + reportrequirement_doc_linkthat fails to download → should still be rejected (permission-fix guidance unchanged)requirement_doc_linkthat downloads cleanly → happy path unchangedCross-repo dependency
Paired backend change in ai-case: https://git.tapsvc.com/qa/automated-test-cases/ai-case/-/merge_requests/24 (validate_prefetch_data + prompt builder updates that surface this skill change).
🤖 Generated with Claude Code