Fix case when "long" type validation allows field to have a "string" type #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…type Since 23be848 (Validate/long: final rewrite) "long" type validation started to handle string representation of numbers. This happens because "tonumber" function implicitly casts some strings to numbers. That allows to pass strings (e.g. "123") instead of "long". This patch fixes such behaviour and introduces corresponding test. Currently we will try to cast to number only fields that have "number" or "cdata" type. Closes #133
olegrok
force-pushed
the
olegrok/133-string-as-long-validation
branch
from
03960bb to
be54c65
Compare
olegrok
commented
Jun 28, 2021
Comment on lines
+772
to
+775
| local n | ||
| if type(data) == 'number' or type(data) == 'cdata' then | ||
| n = tonumber(data) | ||
| end |
Contributor
Author
There was a problem hiding this comment.
Alternative way that also could be used.
Do something like
local _
_ = data > 0 -- it throws for non-numeric types (e.g. for strings)
Contributor
|
23be848 is weird: it does not explain why to use such hacky way to validate a value. Better for JIT? Observed better performance? The code version before 23be848 is easier to understand and now we anyway check the type explicitly. Maybe it would be logical to just revert the commit. However I don't mind your minimal change. |
Contributor
|
At least is solved the observed problem and does not lead to any visible functional degradation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 23be848 (Validate/long: final rewrite) "long" type
validation started to handle string representation of numbers.
This happens because "tonumber" function implicitly casts some
strings to numbers. That allows to pass strings (e.g. "123") instead
of "long".
This patch fixes such behaviour and introduces corresponding
test. Currently we will try to cast to number only fields that
have "number" or "cdata" type.
Closes #133