Skip to content

Fix case when "long" type validation allows field to have a "string" type #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2021
+10 −1
Merged

Fix case when "long" type validation allows field to have a "string" type #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion avro_schema/frontend.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -769,7 +769,10 @@ copy_data = function(stack, schema, data, visited)
stack.remove_last()
return data
elseif schematype == 'long' then
local n = tonumber(data)
local n
if type(data) == 'number' or type(data) == 'cdata' then
n = tonumber(data)
end
Comment on lines +772 to +775
Copy link
Contributor Author

@olegrok olegrok Jun 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternative way that also could be used.
Do something like

local _
_ = data > 0 -- it throws for non-numeric types (e.g. for strings)

if not n then
stack.push(schema, data)
error()
Expand Down
6 changes: 6 additions & 0 deletions test/ddt_suite/validate.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,12 @@ t {
validate_error = 'Not a long: 9223372036854775808ULL'
}

t {
schema = '"long"',
validate = '"42"',
validate_error = 'Not a long: 42'
}

-- note: IEEE 754 double precision floating-point numbers encode
-- fraction with 52 bits, hence when the value is 2^63,
-- the delta must be at least 2^11 (2048) to make a difference.
Expand Down