Skip to content

Conversation

@mRrvz
Copy link
Contributor

@mRrvz mRrvz commented Jan 21, 2021

Closes #49

Copy link
Contributor

@olegrok olegrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for your patch, consider several comments below.

Copy link
Contributor

@olegrok olegrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your changes. Consider several comments below.

Copy link
Contributor

@dokshina dokshina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, fix @olegrok comments and then feel free to merge.

Thanks a lot for these examples!

@mRrvz mRrvz force-pushed the more_select_examples branch from 063db15 to b692ef0 Compare January 29, 2021 15:26
@dokshina dokshina merged commit 8c4d5ed into master Jan 29, 2021
@dokshina dokshina deleted the more_select_examples branch January 29, 2021 15:59
@Totktonada
Copy link
Contributor

@mRrvz How bucket IDs are calculated? I can't get those values from permutations of given field values using require('vshard.hash').<..strcrc32 or mpcrc32..>({<...>}) % <...> + 1.

@mRrvz
Copy link
Contributor Author

mRrvz commented May 6, 2022

@Totktonada hi! To be honest, I don't remember anymore. I think we need to ask @olegrok or @dokshina.

@olegrok
Copy link
Contributor

olegrok commented May 6, 2022

@mRrvz How bucket IDs are calculated? I can't get those values from permutations of given field values using require('vshard.hash').<..strcrc32 or mpcrc32..>({<...>}) % <...> + 1.

I think it's strcrc32 with bucket_count = 3000

@Totktonada
Copy link
Contributor

@olegrok I tried strcrc32 and mpcrc32 with bucket_count = 10000 for the primary key and different permutations of other fields. bucket_count = 3000 is impossible, because we have bucket_id = 7331. If bucket_count is not 10000, but X*1000, I would anyway see the same last three digits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[1pt] Add more select/pairs examples to README.

5 participants