Add read strategy parameters opts #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegrok
reviewed
Mar 16, 2021
Contributor
olegrok
left a comment
olegrok
left a comment
There was a problem hiding this comment.
Hi! Thanks for your patch. I left several thoughts.
dokshina
force-pushed
the
allow-to-specify-read-operations-strategy
branch
from
5a399e9 to
d5cf7f2
Compare
olegrok
reviewed
Mar 16, 2021
olegrok
reviewed
Mar 16, 2021
olegrok
reviewed
Mar 16, 2021
olegrok
reviewed
Mar 16, 2021
olegrok
reviewed
Mar 16, 2021
dokshina
force-pushed
the
allow-to-specify-read-operations-strategy
branch
from
d5cf7f2 to
f8e573b
Compare
olegrok
reviewed
Mar 17, 2021
Added `mode`, `prefer_replica` and `balance` options for read operations (`get`, `select`, `pairs`). According to this parameters one of vshard calls (`callrw`, `callro`, `callbro`, `callre`, `callbre`) is selected.
dokshina
force-pushed
the
allow-to-specify-read-operations-strategy
branch
from
f8e573b to
393e9d9
Compare
olegrok
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
mode,prefer_replicaandbalanceoptions for read operations(
get,select,pairs). According to this parameters one of vshardcalls (
callrw,callro,callbro,callre,callbre) is selected.I didn't forget about
Closes #124