Skip to content

[TNTP-2109] review fixes #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Satbek merged 3 commits into from
Dec 10, 2025
Merged

[TNTP-2109] review fixes #468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ffb837c
make_bucket_ref_err: call BucketRefError only once
Satbek Dec 8, 2025
7ed6449
fix double_buckets_not_applied test, now works for get
Satbek Dec 8, 2025
5044a61
rm manual fast mode enable in select_readview_test
Satbek Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crud/common/sharding/bucket_ref_unref.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@ local M = {
}

local function make_bucket_ref_err(bucket_id, vshard_ref_err)
local err = M.BucketRefError:new(M.BucketRefError:new(
local err = M.BucketRefError:new(
"failed bucket_ref: %s, bucket_id: %s",
vshard_ref_err.name,
bucket_id
))
)
err.bucket_ref_errs = {
{
bucket_id = bucket_id,
Expand Down
4 changes: 2 additions & 2 deletions test/integration/double_buckets_test.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ local not_applied_operations = {
},
get = {
call = function (g, key)
return g.router:call('crud.get', { 'customers', key })
return g.router:call('crud.get', { 'customers', key, {mode = 'write'} })
end,
check_applied = function() end,
check_not_applied = function(not_applied_ids)
Expand All @@ -245,7 +245,7 @@ pgroup_not_applied.test_not_applied = function(g)
),
'test implemented only for 3.1 and greater'
)
t.skip_if(g.params.operation == 'get' and g.params.safe_mode == false, 'todo: rework get')

if g.params.backend == "config" then
local tuples, tuples_count = {}, 1000
for i = 1, tuples_count do
Expand Down
5 changes: 0 additions & 5 deletions test/integration/select_readview_test.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2353,11 +2353,6 @@ end)

pgroup.test_select_switch_master = function(g)
helpers.skip_not_cartridge_backend(g.params.backend)
helpers.call_on_storages(g.cluster, function(server)
server.net_box:eval([[
require('crud.common.rebalance').safe_mode_disable()
]])
end)

helpers.insert_objects(g, 'customers', {
{
Expand Down