Add compat.box_info_cluster_meaning #4584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Totktonada
reviewed
Oct 8, 2024
Comment on lines
25
to
34
| tarantool> box.info.cluster | ||
| --- | ||
| - <cluster information> | ||
| ... | ||
|
|
||
| tarantool> box.info.replicaset | ||
| --- | ||
| - uuid: <replicaset uuid> | ||
| - <... other attributes of the replicaset> | ||
| ... |
There was a problem hiding this comment.
I think it would be convenient to have an example of a real output (preferably with persistent names set).
We say 'entire cluster information' and 'replicaset information' above, but it is very abstract. As a user I can expect a list of instances, their metrics, configuration and so on.
In fact, we have box.info.replicaset.{uuid,name} and box.info.cluster.name. That's all the fields.
Totktonada
reviewed
Oct 8, 2024
Comment on lines
44
to
58
| tarantool> compat.box_info_cluster_meaning = 'old' | ||
| --- | ||
| ... | ||
|
|
||
| tarantool> box.info.cluster | ||
| --- | ||
| - uuid: <replicaset uuid> | ||
| - <... other attributes of the replicaset> | ||
| ... | ||
|
|
||
| tarantool> box.info.replicaset | ||
| --- | ||
| - uuid: <replicaset uuid> | ||
| - <... other attributes of the replicaset> | ||
| ... |
Totktonada
reviewed
Oct 8, 2024
Comment on lines
8
to
11
| Starting from version 3.0, the :ref:`box_info_cluster` table stores the information | ||
| about the entire cluster. In earlier versions, it stored only the current replica set | ||
| information. The ``box_info_cluster_meaning`` compat option allows to define the | ||
| the scope of ``box.info.cluster``: the entire cluster or a single replica set. |
There was a problem hiding this comment.
Can we add something that makes it clear that the new behavior is 3.0.0's default?
After reading this paragraph I was in a doubt: whether it is 3.0.0's behavior that can be enabled using the compat option or it is a default in this version.
Totktonada
approved these changes
Oct 8, 2024
lenkis
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3465
Follow-up on #4427
Deployment: https://docs.d.tarantool.io/en/doc/gh-3465-compat-option/reference/reference_lua/compat/box_info_cluster_meaning/